Merged
Conversation
Author
|
!! Build is fauling due to not updated refs !! |
BoltonDev
reviewed
Dec 13, 2024
Co-authored-by: Bolton <48883340+BoltonDev@users.noreply.github.com>
Misaka-ZeroTwo
requested changes
Dec 13, 2024
Collaborator
Misaka-ZeroTwo
left a comment
Misaka-ZeroTwo
left a comment
There was a problem hiding this comment.
I will double check with the base game code.
EXILED/Exiled.Events/Patches/Events/Server/SelectingRespawnTeam.cs
Outdated
Show resolved
Hide resolved
…m.cs Co-authored-by: Misaka-ZeroTwo <45165615+Misaka-ZeroTwo@users.noreply.github.com>
EXILED/Exiled.Events/Patches/Events/Server/SelectingRespawnTeam.cs
Outdated
Show resolved
Hide resolved
Misaka-ZeroTwo
approved these changes
Dec 13, 2024
LumiFae
reviewed
Dec 13, 2024
LumiFae
left a comment
LumiFae
left a comment
There was a problem hiding this comment.
Just in general, some comments which would be great to implement. We still do need Team on a lot of things just to make stuff useful and easy to implement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Updated EXILED to new game update
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
NW have removed SpawnableTeamType so yeah, we are breaking everything!
Other information:
NW are trying to not break game every major beta update (impossible).
I'll finish this PR tomorrow or if someone else wants to fix
AnnouncingNtfEntranceI can assistTypes of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other